Incompatible declaration of OCA\CMSPico\Http\PicoAssetResponse::cacheFor #197
Description
I moved to Nextcloud 22.2.6 and all of the photos on CMSPico pages disappeared.
in settings/admin/logging
Error PHP Declaration of
OCA\CMSPico\Http\PicoAssetResponse::cacheFor(int $cacheSeconds, bool $public = false):
OCA\CMSPico\Http\PicoAssetResponse must be compatible with
OCP\AppFramework\Http\Response::cacheFor(int $cacheSeconds, bool $public = false, bool $immutable = false) at
.../apps/cms_pico/lib/Http/PicoAssetResponse.php#105
On a pure hunch, I edited .../apps/cms_pico/lib/Http/PicoAssetResponse.php at line 105:
/* public function cacheFor(int $cacheSeconds, bool $public = false): self */
public function cacheFor(int $cacheSeconds, bool $public = false, bool $immutable = false): self
All the photos are now present.
Please could you ensure that the correct fix (as I am unaware of the consequences of my patch) is included in a future release.