Skip to content

Conversation

@ArtificialOwl
Copy link
Member

manual backport of #974

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the CI fails, but apart from that lgtm :)

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the backport/974/974-stable22 branch from 60b1f91 to f22829f Compare March 31, 2022 20:19
@codecov-commenter
Copy link

Codecov Report

Merging #984 (6c5a532) into stable22 (0ba262c) will decrease coverage by 0.00%.
The diff coverage is 3.80%.

❗ Current head 6c5a532 differs from pull request most recent head f22829f. Consider uploading reports for the commit f22829f to get more accurate results

@@              Coverage Diff              @@
##             stable22    #984      +/-   ##
=============================================
- Coverage        0.70%   0.70%   -0.01%     
- Complexity       5672    5692      +20     
=============================================
  Files             289     289              
  Lines           19643   19697      +54     
=============================================
  Hits              138     138              
- Misses          19505   19559      +54     
Impacted Files Coverage Δ
lib/CirclesManager.php 0.00% <0.00%> (ø)
lib/Command/CirclesConfig.php 0.00% <0.00%> (ø)
lib/FederatedItems/CircleConfig.php 0.00% <0.00%> (ø)
lib/FederatedItems/CircleDestroy.php 0.00% <0.00%> (ø)
lib/Model/Circle.php 21.20% <ø> (ø)
lib/Model/Member.php 0.00% <ø> (ø)
lib/Service/CircleService.php 0.00% <0.00%> (ø)
lib/Service/ConfigService.php 2.16% <0.00%> (+0.02%) ⬆️
lib/Service/FederatedUserService.php 0.00% <0.00%> (ø)
lib/Model/Probes/CircleProbe.php 9.52% <12.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba262c...f22829f. Read the comment docs.

@ArtificialOwl ArtificialOwl merged commit b0ff20b into stable22 Mar 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/974/974-stable22 branch March 31, 2022 20:31
@blizzz blizzz mentioned this pull request Apr 13, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants