enforce password on new share #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
fix/noid/enforce-password
branch
2 times, most recently
from
cf9576c to
3fd1b51
Compare
ArtificialOwl
force-pushed
the
fix/noid/enforce-password
branch
from
9398559 to
0588815
Compare
|
/backport to stable23 |
|
/backport to stable22 |
ArtificialOwl
force-pushed
the
fix/noid/enforce-password
branch
2 times, most recently
from
0774f10 to
03a386a
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/enforce-password
branch
from
8de6e9e to
2cf4806
Compare
mejo-
approved these changes
Dec 29, 2021
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the hard part was to keep the clear password on the master instance while creating shares on slaves (in global scale setup)
When a new member is added, or a new share is created, the main instance will generate a list of Clean Passwords and their Hash. Hash will be shared to slaves to be used when generating the share token,
Each slave will use a different hashed password for each members and inherited members of the circle. And will returns the list of generate share,
Main instance get informations about the generate shares, and generate a mail per members and inherited members with the right password from the list.
test in large global scale env,
test in single instance with mass member add,
create password the same way that shared by mail,
check local settings for enforcing password, add also an option in the apps itself