Skip to content

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Feb 1, 2026

Problem

Context: nextcloud/server#57973 and nextcloud/server#49126

Files shared with teams were not syncing properly on desktop clients. When files were added, modified, or deleted in team-shared directories, the ETag was correctly updated in the database but clients received stale ETags from the distributed cache, preventing synchronization.

Root causes:

  1. The clearCache() method in ShareWrapperService was broken - it used singleId as the cache key but actual keys follow the format singleId#nodeId#probeSum, causing cache invalidation to silently fail
  2. No event listeners existed to detect file modifications and trigger cache invalidation - cache was only cleared when shares or memberships changed, never when files themselves were modified

Note

While testing, please enable debug mode to print debug messages.

@solracsf solracsf force-pushed the fixCacheInvalidation branch 2 times, most recently from c440368 to b17f1e8 Compare February 1, 2026 09:00
@solracsf solracsf marked this pull request as ready for review February 1, 2026 09:00
@solracsf solracsf self-assigned this Feb 1, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the fixCacheInvalidation branch from b17f1e8 to 2e1669b Compare February 1, 2026 09:22
@Ornanovitch

This comment was marked as resolved.

@Ornanovitch
Copy link

/backport to stable33

@Ornanovitch
Copy link

/backport to stable32

@Ornanovitch
Copy link

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants