fix: cache invalidation issues #2330
Open
+205
−117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Context: nextcloud/server#57973 and nextcloud/server#49126
Files shared with teams were not syncing properly on desktop clients. When files were added, modified, or deleted in team-shared directories, the ETag was correctly updated in the database but clients received stale ETags from the distributed cache, preventing synchronization.
Root causes:
clearCache()method inShareWrapperServicewas broken - it usedsingleIdas the cache key but actual keys follow the formatsingleId#nodeId#probeSum, causing cache invalidation to silently failNote
While testing, please enable
debugmode to print debug messages.