fix(groups): add repair step for group circles sync and adjust 'circles:sync --groups' command #2310
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianscheid
requested review from
ArtificialOwl and
provokateurin
as code owners
cristianscheid
force-pushed
the
fix/2291/sync-groups-repair-step
branch
2 times, most recently
from
4cc3e6c to
7290d3a
Compare
| } | ||
|
|
||
| $group = $this->groupManager->get($groupId); | ||
| if ($group->count() <= count($members)) { |
Member
There was a problem hiding this comment.
Because you mentioned it in the PR description: I think this check should be removed to avoid sync issues. If the sync is broken for some reason and one user is added and one users is removed, then this would prevent syncing. I suppose this is done for performance reasons, but it might be better to just always sync or at least implement a better detection than the member count.
lib/Service/SyncService.php
Outdated
Comment on lines
280
to
286
| $members = []; | ||
| foreach ($this->memberRequest->getMembers($circle->getSingleId()) as $member) { | ||
| if ($member->getUserType() === Member::TYPE_APP) { | ||
| continue; | ||
| } | ||
| $members[] = $member->getSingleId(); | ||
| } |
Member
There was a problem hiding this comment.
IMO array_filter is cleaner for such operations.
cristianscheid
force-pushed
the
fix/2291/sync-groups-repair-step
branch
from
7290d3a to
ef563f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed accidentally. Reopened in #2317.