-
Notifications
You must be signed in to change notification settings - Fork 56
fix: replace circle/circles text with team/teams #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yemkareems <yemkareems@gmail.com>
|
/backport to stable32 |
|
/backport to stable31 |
rakekniven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general use lowercase for team
| $this->setName('circles:manage:config') | ||
| ->setDescription('edit config/type of a Circle') | ||
| ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle') | ||
| ->setDescription('edit config/type of a Team') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| ->addArgument( | ||
| 'config', InputArgument::IS_ARRAY, | ||
| 'list of value to change in the configuration of the Circle' | ||
| 'list of value to change in the configuration of the Team' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| $this->setName('circles:manage:edit') | ||
| ->setDescription('edit displayName or description of a Circle') | ||
| ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle') | ||
| ->setDescription('edit displayName or description of a Team') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| $this->setName('circles:manage:leave') | ||
| ->setDescription('simulate a user joining a Circle') | ||
| ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle') | ||
| ->setDescription('simulate a user joining a Team') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| ->addOption('backend', '', InputOption::VALUE_NONE, 'include Backend Circles') | ||
| ->addOption('single', '', InputOption::VALUE_NONE, 'returns only Single Circles') | ||
| ->addOption('all', '', InputOption::VALUE_NONE, 'include all Circles'); | ||
| ->addOption('personal', '', InputOption::VALUE_NONE, 'include Personal Teams') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| $instances = $this->memberRequest->getMemberInstances($event->getCircle()->getSingleId()); | ||
| if (!in_array($event->getSender(), $instances)) { | ||
| throw new FederatedEventException('Instance have no members in this Circle'); | ||
| throw new FederatedEventException('Instance have no members in this Team'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| } | ||
|
|
||
| throw new FederatedEventDSyncException('Could not verify Circle'); | ||
| throw new FederatedEventDSyncException('Could not verify Team'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| 128 => 'Cannot add Circle as its own Member', | ||
| 125 => 'The designed team cannot be added', | ||
| 126 => 'Team only accepts local users', | ||
| 127 => 'Remote Users are not accepted in a non-federated Team', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| 125 => 'The designed team cannot be added', | ||
| 126 => 'Team only accepts local users', | ||
| 127 => 'Remote Users are not accepted in a non-federated Team', | ||
| 128 => 'Cannot add Team as its own Member', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
| 129 => 'Member does not contains a patron', | ||
| 130 => 'Member is invited by an entity that does not belongs to the instance at the origin of the request', | ||
| 131 => 'Member is a non-local Circle', | ||
| 131 => 'Member is a non-local Team', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team -> team
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Resolves: #2219
fix: replace circle/circles text with team/teams