feat: dismiss notification when accepting an invitation #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/810/mark-notification-as-processed-on-accept
branch
from
7628e6d
to
13d6697
Compare
ArtificialOwl
approved these changes
Jul 30, 2024
|
Thanks @kesselb, carefully reviewed |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
This was referenced Jul 30, 2024
AndyScherzinger
deleted the
bug/810/mark-notification-as-processed-on-accept
branch
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #810
I only tested the case (circle needs invitation, user is invited, user press accept, notification is gone).
Needs a careful review.