Merged
Conversation
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
===========================================
- Coverage 0.69% 0.69% -0.01%
- Complexity 5739 5741 +2
===========================================
Files 291 291
Lines 19859 19871 +12
===========================================
Hits 139 139
- Misses 19720 19732 +12
Continue to review full report at Codecov.
|
CarlSchwan
approved these changes
Jun 14, 2022
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
This was referenced Jun 14, 2022
Member
Author
|
/backport to stable24 |
|
The backport to stable24 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a current minor issue making the migration process to run even if there is nothing to migrate (fresh instance).
The full migration process will reset memberships and recreate them, which is useless on a fresh instance.
On old instance (pre-22 with Circles already installed), Because the old tables were not drop after the migration, a negative use-case could be trigger:
This fix will check that new table are not used and that the old table exists.
The drop of old tables will be done in 25