build: migrate tests from Karama and Jasmine to Vitest#931
Merged
Conversation
The test were migrated by: 1. running `npx jest-codemod` 2. running `npx codemod jest-to-vitest` 3. replacing calls to `pending` 4. replacing `fail` with `assert.fail` Resolves #902 Signed-off-by: Oleksandr Dzhychko <oleksandr@dzhychko.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
approved these changes
Mar 22, 2025
st3iny
added
4. to release
Contributor
Author
|
Great, glad I could help. Thanks for developing and providing this library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test were migrated by:
npx jest-codemodnpx codemod jest-to-vitestpendingfailwithassert.failResolves #905
The existing tests had ESLint problems.
So I was not sure how you handle such problems in tests.
Therefore, I also didn't fix ESLint problems introduced by the migrations.
Most of the new problems are in regard to style.
All of them can be automatically fixed by running
npx eslint test/unit --fix.