chore(deps): update dependency @nextcloud/eslint-config to ^9.0.1 (main)#8583
chore(deps): update dependency @nextcloud/eslint-config to ^9.0.1 (main)#8583renovate[bot] wants to merge 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
46e1d99 to
8850bdb
Compare
1b7baee to
92ba2f9
Compare
92ba2f9 to
29426dc
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Steps to reproduce: - `npm uninstall @nextcloud/eslint-config` - `npm install @nextcloud/eslint-config@9.0.1` Also disabled new erros for now. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
29426dc to
cb078a4
Compare
There was a problem hiding this comment.
@GVodyanov @SebastianKrupinski Could you review this?
I'm adding TS (and linting) support to test and need to upgrade @nextcloud/eslin-config to cleanly install @vitest/eslint-plugin@1.6.1 😉
See #8630
| 'preserve-caught-error': 'warn', | ||
| '@nextcloud/no-deprecated-library-props': 'warn', | ||
| 'vue/custom-event-name-casing': 'warn', | ||
| 'no-useless-assignment': 'warn', |
There was a problem hiding this comment.
note: I configured newly occurred errors to be warnings for now.
Had a quick lock and non of them hinted upon a bug to me.
But all seemed legit and I like to see them, when I work on code. So I set "warn" instead of "off".
For the same reason I changed from "off" to "warn" for the existing relaxed rules.
| 'no-console': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| 'vue/multi-word-component-names': 'off', | ||
| 'no-console': 'warn', |
There was a problem hiding this comment.
question: In most cases we want to use @nextcloud/logger instead of console.warn/degbug, right?
This PR contains the following updates:
^9.0.0-rc.8→^9.0.1Release Notes
nextcloud-libraries/eslint-config (@nextcloud/eslint-config)
v9.0.1Compare Source
Fixed
vue/attributes-orderandvue/order-in-componentsinstead of warn #1445 (susnux)no-deprecated-library-*rules incorrectly behave fornextcloud/vuesyntax #1452 (Antreesy)@nextcloud/vuedirectory structures #1454 (ShGKme)v9.0.0Compare Source
Breaking
This package now is using ESLint v10 and requires ESLint flat configurations.
Please refer to the README on how to adjust your configuration for flat config.
Potential pitfalls
Some of the used eslint plugins still keep a ESLint v8 compatibility,
this can cause some issues if not all packages are updated to the ESLint v10 compatible version.
If you see a linter error like the one below make sure to update all nested dependencies,
either using the sledge hammer method (remove the lock file and run
npm i) or by runningnpm update.Added
vue/no-useless-v-bindrule #1063 (susnux)vue/prefer-separate-static-classrule #1065 (susnux).gitignore#1108 (susnux)<script>#1262 (ShGKme)<template>#1263 (ShGKme)Fixed
stylisticrules config #914appNameandappVersionglobal + fix access #972@typescript-eslint/no-shadow#993import typefor type only imports #977l10nandjsdirectory for apps #1061 (susnux)@typescript-eslint/no-shadow#993 (ShGKme)@stylistic/quotesrule #1109 (susnux)nmethod #1112 (susnux)no-irregular-whitespace#1129 (susnux)@stylistic/exp-list-styleto resolve array edge-cases #1203 (susnux)Changed
@ts-expect-error#915npm lintwithout compile step #975 (susnux)@nextcloudplugin #1278 (susnux)@eslint/jsonto 2.0.0@stylistic/eslint-pluginto 5.7.0eslint-config-flat-gitignoreto 2.1.0eslint-plugin-antfuto 3.2.3eslint-plugin-jsdocto 63.0.4eslint-plugin-perfectionistto 5.9.1eslint-plugin-vueto 10.9.2fast-xml-parserto 5.9.0globalsto 17.7.0semverto 7.8.4sort-package-jsonto 4.0.0typescript-eslintto 8.62.0v9.0.0-rc.10Compare Source
What's Changed
🚀 Enhancements
🐛 Fixed bugs
Other Changes
Full Changelog: nextcloud-libraries/eslint-config@v9.0.0-rc.9...v9.0.0-rc.10
v9.0.0-rc.9Compare Source
What's Changed
ℹ️ Notes
If you are upgrading from a previous RC of this library and you have customized your ESLint config:
In #1278 we merged some of the provided plugins,
so if you have custom rule overrides then you might need to adjust your ESLint config.
Merged the
nextcloud-l10nplugin into thenextcloudpluginMerged the rules into the Nextcloud plugin, new rule names:
@nextcloud-l10n/enforce-ellipsis->@nextcloud/l10n-enforce-ellipsis@nextcloud-l10n/nonbreaking-space->@nextcloud/l10n-non-breaking-spaceThe vue variants have been merged into the base rules.
Renamed
@nextcloud/no-deprecationsand@nextcloud/no-removed-apisRenamed so it does not confuse with vue rules after merging the plugins.
New rule names:
@nextcloud/no-deprecations->@nextcloud/no-deprecated-globals@nextcloud/no-removed-apis->@nextcloud/no-removed-globalsMerged
@nextcloud-vueplugin into the@nextcloudpluginRule name changes:
@nextcloud-vue/no-deprecated-exports->@nextcloud/no-deprecated-library-exports@nextcloud-vue/no-deprecated-props->@nextcloud/no-deprecated-library-props🚀 Enhancements
@nextcloudplugin by @susnux in #1278Other Changes
Full Changelog: nextcloud-libraries/eslint-config@v9.0.0-rc.8...v9.0.0-rc.9
Configuration
📅 Schedule: (in timezone Europe/Berlin)
* 0-3 1 * *)🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.