Add theme color highlight to Today date #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dugite-code Thx for your pull-request! :) I think if we add the blue circle around it, we should remove the yellow background.
@skjnldsv @jancborchardt any opinions? ^ |
|
Agree with your enhancement proposals @georgehrke. :) @dugite-code can you adjust the pull request? |
|
I've just finished checking on multiple browsers with the suggested changes.
|
- Add margin to the circle - Fix Text alignment - Fix circle size on single number dates - Make text bold - Remove today yellow color background
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
|
I fixed the build and adjusted the margin a bit to make it a little more rounded. Don't hesitate to drop my latest commit if you don't like it. Before |
tcitworld
approved these changes
Nov 11, 2018
tcitworld
added
3. to review
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add circular highlight based on Primary theme colors as discussed in pull request #818