Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

Summary

Adds functionality to automatically created tentative time blocking events in calendars when a proposal is created.

Requires

nextcloud/server#53831

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.68%. Comparing base (0b8f6b4) to head (8d68329).
⚠️ Report is 123 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7315   +/-   ##
=======================================
  Coverage   13.68%   13.68%           
=======================================
  Files         218      218           
  Lines       11174    11174           
  Branches     2684     2697   +13     
=======================================
  Hits         1529     1529           
  Misses       9295     9295           
  Partials      350      350           
Flag Coverage Δ
javascript 13.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndyScherzinger
Copy link
Member

Server PR has been merged 👍

@st3iny
Copy link
Member

st3iny commented Sep 2, 2025

Needs a rebase I think.

@SebastianKrupinski
Copy link
Contributor Author

Needs a rebase I think.

It does, I'll take care of it after the call

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposals-time-blockers branch from 1076baf to d5e5db2 Compare September 2, 2025 14:13
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Sep 2, 2025
@SebastianKrupinski
Copy link
Contributor Author

Psalm is still failing as the new server changes are not being pulled yet, I'll try again tomorrow

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposals-time-blockers branch from d5e5db2 to 86fc78f Compare September 3, 2025 14:21
@SebastianKrupinski
Copy link
Contributor Author

I see the issue with psalm, i'll fix it

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposals-time-blockers branch from 86fc78f to 14ac56d Compare September 3, 2025 14:28
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing to fix (php-cs):

   1) lib/Service/Proposal/ProposalService.php
      ---------- begin diff ----------
--- /home/runner/work/calendar/calendar/lib/Service/Proposal/ProposalService.php
+++ /home/runner/work/calendar/calendar/lib/Service/Proposal/ProposalService.php
@@ -616,7 +616,7 @@
 				$this->calendarManager->handleIMip(
 					$participantUser->getUID(),
 					$template->serialize(),
-					$reason !== 'D' ? ['absent' =>  'create'] : []
+					$reason !== 'D' ? ['absent' => 'create'] : []
 				);
 			} catch (Exception $e) {
 				$this->logger->error($e->getMessage(), ['app' => 'calendar', 'exception' => $e]);

      ----------- end diff -----------

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposals-time-blockers branch from 14ac56d to dcf153f Compare September 3, 2025 16:23
@SebastianKrupinski
Copy link
Contributor Author

One more thing to fix (php-cs):

Yeah, I always forget to run this, especially on minor changes

@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review September 3, 2025 16:25
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Sep 3, 2025
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@st3iny st3iny merged commit 559ab71 into main Sep 24, 2025
41 checks passed
@st3iny st3iny deleted the feat/meeting-proposals-time-blockers branch September 24, 2025 09:38
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants