-
Notifications
You must be signed in to change notification settings - Fork 290
feat: Meeting proposals calendar time blockers #7315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Server PR has been merged 👍 |
|
Needs a rebase I think. |
It does, I'll take care of it after the call |
1076baf to
d5e5db2
Compare
|
Psalm is still failing as the new server changes are not being pulled yet, I'll try again tomorrow |
d5e5db2 to
86fc78f
Compare
|
I see the issue with psalm, i'll fix it |
86fc78f to
14ac56d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing to fix (php-cs):
1) lib/Service/Proposal/ProposalService.php
---------- begin diff ----------
--- /home/runner/work/calendar/calendar/lib/Service/Proposal/ProposalService.php
+++ /home/runner/work/calendar/calendar/lib/Service/Proposal/ProposalService.php
@@ -616,7 +616,7 @@
$this->calendarManager->handleIMip(
$participantUser->getUID(),
$template->serialize(),
- $reason !== 'D' ? ['absent' => 'create'] : []
+ $reason !== 'D' ? ['absent' => 'create'] : []
);
} catch (Exception $e) {
$this->logger->error($e->getMessage(), ['app' => 'calendar', 'exception' => $e]);
----------- end diff -----------
14ac56d to
dcf153f
Compare
Yeah, I always forget to run this, especially on minor changes |
|
/backport to stable6.0 |
AndyScherzinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
dcf153f to
8d68329
Compare
Summary
Adds functionality to automatically created tentative time blocking events in calendars when a proposal is created.
Requires
nextcloud/server#53831