-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling: iframe #473
Spelling: iframe #473
Conversation
@comradekingu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke and @tcitworld to be potential reviewers. |
That refers to the tag name of iframes in HTML, not the spelling in everyday use. |
👎 |
@georgehrke That is what I was trying to reference, without going to the length of adding -tags. |
Same opinion. 👎
Does it work only on Safari ? :p You really shouldn't use this website as a reference. |
https://en.wikipedia.org/wiki/HTML_element#Frames – »iframe« is used there in the body text too. :) |
@jancborchardt So make it »Iframe to integrate«? The »put in« seems weird to me |
@tcitworld Mistook it for w3c.org |
As we capitalize the first letter because its at the start of the sentence it will be
I still don't get why you want to add something. |
@georgehrke I didn't think of that. Will do. |
let me squash and rebase |
It used to be IFRAME https://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#h-16.5 for reasons unknown, but now it is "iframe" https://www.w3.org/TR/2014/REC-html5-20141028/embedded-content-0.html#the-iframe-element Added something to start of sentence to avoid issue with Iframe or iframe. "Iframe" to start sentence.
1465cef
to
0ac3724
Compare
It used to be IFRAME https://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#h-16.5
for reasons unknown, but now it is "iframe"
https://www.w3.org/TR/2014/REC-html5-20141028/embedded-content-0.html#the-iframe-element
Added something to start of sentence to avoid issue with Iframe or iframe.