Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling: iframe #473

Merged
merged 1 commit into from
May 29, 2017
Merged

Spelling: iframe #473

merged 1 commit into from
May 29, 2017

Conversation

comradekingu
Copy link
Contributor

It used to be IFRAME https://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#h-16.5
for reasons unknown, but now it is "iframe"
https://www.w3.org/TR/2014/REC-html5-20141028/embedded-content-0.html#the-iframe-element
Added something to start of sentence to avoid issue with Iframe or iframe.

@mention-bot
Copy link

@comradekingu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke and @tcitworld to be potential reviewers.

@georgehrke
Copy link
Member

https://www.w3.org/TR/2014/REC-html5-20141028/embedded-content-0.html#the-iframe-element

That refers to the tag name of iframes in HTML, not the spelling in everyday use.
The correct form (imho) is iFrame. As it is the first word of the sentence, we capitalize the first letter
-> IFrame

@georgehrke
Copy link
Member

👎

@georgehrke georgehrke added the 3. to review Waiting for reviews label May 25, 2017
@comradekingu
Copy link
Contributor Author

@georgehrke That is what I was trying to reference, without going to the length of adding -tags.
I don't understand where the "F" comes from.
https://www.w3schools.com/html/html_iframe.asp

@tcitworld
Copy link
Member

Same opinion. 👎

The correct form (imho) is iFrame.

Does it work only on Safari ? :p

https://www.w3schools.com/html/html_iframe.asp

You really shouldn't use this website as a reference.

@jancborchardt
Copy link
Member

https://en.wikipedia.org/wiki/HTML_element#Frames – »iframe« is used there in the body text too. :)

@georgehrke
Copy link
Member

@jancborchardt So make it »Iframe to integrate«?

The »put in« seems weird to me

@comradekingu
Copy link
Contributor Author

@tcitworld Mistook it for w3c.org
I don't know. "iframe" is possibly correct, it may be "Iframe", but certainly not "IFrame".
@georgehrke Enclose in iframe tags/element maybe?

@georgehrke
Copy link
Member

"iframe" is possibly correct, it may be "Iframe",

As we capitalize the first letter because its at the start of the sentence it will be Iframe in both cases.

Enclose in iframe tags/element maybe?

I still don't get why you want to add something. Iframe to integrate would be perfectly fine in my opinion. Can you elaborate please?

@comradekingu
Copy link
Contributor Author

comradekingu commented May 27, 2017

@georgehrke I didn't think of that. Will do.
Edit: I filter things starting with "i" into the 'dubious' category, so never sure whether to capitalize or not.

@georgehrke
Copy link
Member

let me squash and rebase

It used to be IFRAME https://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#h-16.5
for reasons unknown, but now it is "iframe"
https://www.w3.org/TR/2014/REC-html5-20141028/embedded-content-0.html#the-iframe-element
Added something to start of sentence to avoid issue with Iframe or iframe.

"Iframe" to start sentence.
@georgehrke georgehrke force-pushed the comradekingu-patch-2 branch from 1465cef to 0ac3724 Compare May 28, 2017 08:37
@georgehrke georgehrke merged commit 8ca9f10 into master May 29, 2017
@georgehrke georgehrke deleted the comradekingu-patch-2 branch May 29, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants