Skip to content

Conversation

@Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Jun 2, 2021

Reported by a Transifex translator.

Reported by a Transifex translator.
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #3140 (fcc43b2) into master (e69a53a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3140   +/-   ##
=========================================
  Coverage     28.92%   28.92%           
  Complexity      121      121           
=========================================
  Files           157      157           
  Lines          5715     5715           
  Branches        839      839           
=========================================
  Hits           1653     1653           
  Misses         4062     4062           
Flag Coverage Δ
javascript 23.45% <ø> (ø)
php 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69a53a...fcc43b2. Read the comment docs.

@ChristophWurst
Copy link
Member

It's the column header for a relative date. This will now say Deleted on2 days ago. This doesn't seem right. Should it be just Deleted maybe?

@Valdnet
Copy link
Contributor Author

Valdnet commented Jun 2, 2021

Should it be just Deleted maybe?

A very good solution. I thought so too (because it's in the table), but I wanted your opinion.

Corrected 😉. @ChristophWurst I am asking you to merge.

@ChristophWurst ChristophWurst merged commit 9900dc1 into master Jun 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the Valdnet-patch-1 branch June 4, 2021 11:19
@ChristophWurst ChristophWurst added the Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants