-
Notifications
You must be signed in to change notification settings - Fork 290
Add a footer for trash bin #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3130 +/- ##
============================================
- Coverage 28.92% 28.91% -0.02%
Complexity 121 121
============================================
Files 157 157
Lines 5715 5717 +2
Branches 839 839
============================================
Hits 1653 1653
- Misses 4062 4064 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: greta <gretadoci@gmail.com>
9ce9b5c to
7b32067
Compare
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GretaD please give this a final test but I think we can merge this :)
|
Is it worth it to handle the property being not found? Since nextcloud/server#27348 is not yet in the latest beta, there's a very nice |
|
Sure, some robustness would be good! |

Fixes #3126