Skip to content

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented May 31, 2021

@GretaD GretaD self-assigned this May 31, 2021
@GretaD GretaD requested a review from ChristophWurst May 31, 2021 20:08
@GretaD GretaD added 2. developing Work in progress enhancement New feature request labels May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #3130 (9ce9b5c) into master (e69a53a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 9ce9b5c differs from pull request most recent head 7b32067. Consider uploading reports for the commit 7b32067 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3130      +/-   ##
============================================
- Coverage     28.92%   28.91%   -0.02%     
  Complexity      121      121              
============================================
  Files           157      157              
  Lines          5715     5717       +2     
  Branches        839      839              
============================================
  Hits           1653     1653              
- Misses         4062     4064       +2     
Flag Coverage Δ
javascript 23.44% <0.00%> (-0.01%) ⬇️
php 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69a53a...7b32067. Read the comment docs.

Signed-off-by: greta <gretadoci@gmail.com>
@ChristophWurst ChristophWurst force-pushed the add/delete-time-trashbin branch from 9ce9b5c to 7b32067 Compare June 2, 2021 16:57
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GretaD please give this a final test but I think we can merge this :)

@ChristophWurst ChristophWurst merged commit e426ef7 into master Jun 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the add/delete-time-trashbin branch June 4, 2021 06:46
@tcitworld
Copy link
Member

Is it worth it to handle the property being not found?

Since nextcloud/server#27348 is not yet in the latest beta, there's a very nice NaN.
image

@ChristophWurst
Copy link
Member

Sure, some robustness would be good!

@ChristophWurst ChristophWurst added the Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature request Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tell the user when their trashbin elements will be deleted

4 participants