Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone names #2292

Merged
merged 1 commit into from
May 30, 2020
Merged

Fix timezone names #2292

merged 1 commit into from
May 30, 2020

Conversation

tcitworld
Copy link
Member

Some timezones have more than one / in their name, and only the first part was being used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
Before After
nextcloud_tz_before nextcloud_tz_after

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added 3. to review Waiting for reviews javascript Pull requests that update Javascript code labels May 29, 2020
@tcitworld tcitworld added this to the 2.1.0 milestone May 29, 2020
@tcitworld tcitworld requested a review from georgehrke May 29, 2020 19:53
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #2292 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2292      +/-   ##
============================================
+ Coverage     27.63%   27.64%   +0.01%     
  Complexity      103      103              
============================================
  Files           144      144              
  Lines          5287     5288       +1     
  Branches        798      798              
============================================
+ Hits           1461     1462       +1     
  Misses         3826     3826              
Flag Coverage Δ Complexity Δ
#javascript 22.27% <100.00%> (+0.01%) 0.00 <0.00> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
src/utils/timezone.js 96.66% <100.00%> (+0.11%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827a71b...c37f762. Read the comment docs.

@georgehrke georgehrke merged commit f3630d2 into master May 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-typezone-names branch May 30, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants