Skip to content

Conversation

@georgehrke
Copy link
Member

fixes #2063

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke requested a review from tcitworld May 5, 2020 09:53
@georgehrke georgehrke added the 3. to review Waiting for reviews label May 5, 2020
@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #2243 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2243      +/-   ##
============================================
- Coverage     27.72%   27.66%   -0.07%     
  Complexity      103      103              
============================================
  Files           143      143              
  Lines          5269     5281      +12     
  Branches        797      797              
============================================
  Hits           1461     1461              
- Misses         3808     3820      +12     
Flag Coverage Δ Complexity Δ
#javascript 22.28% <0.00%> (-0.06%) 0.00 <0.00> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ts/AppNavigation/CalendarList/CalendarListItem.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...alendarList/CalendarListItemSharingPublishItem.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../CalendarList/CalendarListItemSharingShareItem.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...Navigation/CalendarList/PublicCalendarListItem.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/components/AppNavigation/EmbedTopNavigation.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/components/AppNavigation/Settings.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...s/AppNavigation/Settings/SettingsImportSection.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../AppNavigation/Settings/SettingsTimezoneSelect.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/components/Editor/Invitees/InviteesList.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c13e3...d57b254. Read the comment docs.

@georgehrke georgehrke merged commit aaa064a into master May 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/2063/ocp_toast_to_nc_dialogs branch May 5, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace OCP.Toast with Nextcloud/dialogs

4 participants