Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom color per event #1614

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Oct 29, 2019

fixes #71

1. 2.
6ED5BBDD-4868-4BAA-80FC-F2F9457F994C 15AD19CF-D65D-48C3-87B0-50025FD35A62
3. 4.
EADC6DE0-E763-4EBC-ADF6-CE26578502C5 9EFD2ADC-335E-44C5-903F-5E1D268B7B4D
  1. By default, it's just showing the calendar color (and no x button)
  2. Color picker
  3. Once the user selected a custom color, they can press the x button to go back to the calendar color
  4. Read-only view

@georgehrke georgehrke added the 2. developing Work in progress label Oct 29, 2019
@simonspa

This comment has been minimized.

@georgehrke georgehrke force-pushed the feature/71/color-per-event branch 2 times, most recently from a118a32 to 98be1f7 Compare January 13, 2020 09:05
@georgehrke georgehrke force-pushed the feature/71/color-per-event branch from 98be1f7 to 4b2360b Compare February 25, 2020 12:03
…or.js

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the feature/71/color-per-event branch from 4b2360b to 714ece4 Compare March 2, 2020 09:20
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the feature/71/color-per-event branch from 714ece4 to ccfa924 Compare March 2, 2020 09:40
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 2, 2020
@georgehrke georgehrke requested a review from tcitworld March 2, 2020 10:02
@georgehrke
Copy link
Member Author

@tcitworld Should we just hide the color in read-only mode?

@tcitworld
Copy link
Member

Not sure the themed illustration pic would be enough, so I think we should keep it for now.

Btw, the "x button" to reset the color is hard to find at the end of the line (and low contrast).

@georgehrke
Copy link
Member Author

If i remove the double opacity from __info and just leave the opacity from the ActionButton itself, it looks like this:
CAC6AFF9-E88F-476F-BB4F-DBEC3B67988B

Putting the X right next to the color looks a bit odd imho:
3383E286-7949-4A57-BFE7-B8FDF7A85DAF

@tcitworld
Copy link
Member

I think it makes more sense if it's a "reset" icon next to it.

@georgehrke
Copy link
Member Author

We could use icon-history for that:
3CDA8690-A2A5-4E0B-8039-B2717E959F01

@georgehrke georgehrke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 2, 2020
@raimund-schluessler
Copy link
Member

How would it look with the color input being the full width? Then everything would be aligned.

@georgehrke
Copy link
Member Author

georgehrke commented Mar 2, 2020

How would it look with the color input being the full width? Then everything would be aligned.

I tried that, but that looks very weird.
It's way too big and dominant for a simple color-picker:
0A62279E-FBAA-466C-9346-6610CEAEC4B0

@tcitworld
Copy link
Member

We could display the CSS color name aside the input since we have it (joking, don't do that).

What we have in #1614 (comment) seems fine to me.

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
Copy link
Member Author

I changed it to #1614 (comment)

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 2, 2020
@georgehrke
Copy link
Member Author

@tcitworld Good to go? :)

@georgehrke georgehrke merged commit a5a9344 into master Mar 2, 2020
@georgehrke georgehrke deleted the feature/71/color-per-event branch March 2, 2020 13:14
@ghost
Copy link

ghost commented Feb 8, 2021

When I change the color, it looks good on the day and week calendar views, but appears merely as a small colored dot on the month view. Being slightly color blind, the small dot is easy to miss. Can we change the background color on the month view, like we do on the day and week views?

@ChristophWurst
Copy link
Member

@MartinConsultingServicesInc use the forums please https://help.nextcloud.com/c/apps/calendar/42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom color per event [$75]
5 participants