-
Notifications
You must be signed in to change notification settings - Fork 290
Open
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care ofFeature: Calendar listFeature: SharingLanguage: PHPIssues that require PHP to be fixedIssues that require PHP to be fixedbuggood first issueSmall tasks with clear documentation about how and in which place you need to fix things in.Small tasks with clear documentation about how and in which place you need to fix things in.skill:frontendIssues and PRs that require JavaScript/Vue/styling development skillsIssues and PRs that require JavaScript/Vue/styling development skills
Description
Steps to reproduce
- Check out Dav respect disallow sharing with groups server#25658
- Disallow sharing with groups in the sharing settings
- Open the share section on a calendar
Expected behaviour
No mention of "groups" in the placeholder.
Actual behaviour
Mention of "groups" in the placeholder.
How to fix
- Fetch the config and inject it in the initialstate service in
ViewController - add the config into
loadSettingsFromServerinCalendar.vue - get the config from the store and condition the group showing in strings in
CalendarListItemSharingSearch.vue - add some tests for good mesure
Metadata
Metadata
Assignees
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care ofFeature: Calendar listFeature: SharingLanguage: PHPIssues that require PHP to be fixedIssues that require PHP to be fixedbuggood first issueSmall tasks with clear documentation about how and in which place you need to fix things in.Small tasks with clear documentation about how and in which place you need to fix things in.skill:frontendIssues and PRs that require JavaScript/Vue/styling development skillsIssues and PRs that require JavaScript/Vue/styling development skills