Skip to content

Don't show groups in share placeholder if group sharing is disabled #2946

@tcitworld

Description

@tcitworld

Steps to reproduce

  1. Check out Dav respect disallow sharing with groups server#25658
  2. Disallow sharing with groups in the sharing settings
  3. Open the share section on a calendar

Expected behaviour

No mention of "groups" in the placeholder.

Actual behaviour

Mention of "groups" in the placeholder.

How to fix

  • Fetch the config and inject it in the initialstate service in ViewController
  • add the config into loadSettingsFromServer in Calendar.vue
  • get the config from the store and condition the group showing in strings in CalendarListItemSharingSearch.vue
  • add some tests for good mesure

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofFeature: Calendar listFeature: SharingLanguage: PHPIssues that require PHP to be fixedbuggood first issueSmall tasks with clear documentation about how and in which place you need to fix things in.skill:frontendIssues and PRs that require JavaScript/Vue/styling development skills

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions