-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(App): Use NC components #551
Conversation
DorraJaouad
commented
Feb 6, 2024
•
edited
Loading
edited
- Added @nextcloud/dialogs to dependencies to inform user when there is an error.
- Relaced native HTML elements with NC components in App components.
- Fixed name attr.
Before | After |
---|---|
you need to commit the compiled JS assets
or you summon the bot with a comment: |
I was waiting for a confirmation to nothing to change before I compile |
/compile / |
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
bff1cf8
to
133fec9
Compare
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While on it change the screenshot in https://github.com/nextcloud/bruteforcesettings/tree/master/screenshots ?
Yes I will |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/551/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17462559 62e07b14
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/551/stable28 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |