Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(App): Use NC components #551

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

DorraJaouad
Copy link
Collaborator

@DorraJaouad DorraJaouad commented Feb 6, 2024

  • Added @nextcloud/dialogs to dependencies to inform user when there is an error.
  • Relaced native HTML elements with NC components in App components.
  • Fixed name attr.
Before After
image image

@DorraJaouad
Copy link
Collaborator Author

DorraJaouad commented Feb 6, 2024

/backport 1746255 62e07b1 to stable28

@nickvergessen
Copy link
Member

you need to commit the compiled JS assets

npm ci && npm run build

or you summon the bot with a comment: /compile /

@DorraJaouad
Copy link
Collaborator Author

I was waiting for a confirmation to nothing to change before I compile

@DorraJaouad
Copy link
Collaborator Author

/compile /

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/update-component branch from bff1cf8 to 133fec9 Compare February 9, 2024 12:59
@DorraJaouad
Copy link
Collaborator Author

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/App.vue Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
@DorraJaouad
Copy link
Collaborator Author

While on it change the screenshot in master/screenshots ?

Yes I will

@DorraJaouad DorraJaouad merged commit 00a7ddc into master Feb 9, 2024
28 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/update-component branch February 9, 2024 15:37
Copy link

backportbot bot commented Feb 9, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/551/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17462559 62e07b14

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/551/stable28

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants