Fix: delete assistant modal title #180
Conversation
| @@ -6,7 +6,7 @@ | |||
| <NcModal v-if="show" | |||
| :size="modalSize" | |||
| :can-close="false" | |||
| :name="t('assistant', 'Nextcloud Assistant')" | |||
| :label-id="t('assistant', 'Nextcloud Assistant')" | |||
There was a problem hiding this comment.
I'm not sure if labelId is the right choice for this, as it takes an element id, I think, not a free-form string.
There was a problem hiding this comment.
Ah damn you're right. i just checked, I cannot give the modal an aria label directly, it has to be through name or another element. What's the best way to work with that, creating a dummy element somehow?
There was a problem hiding this comment.
You can try setting an aria-label to the modal component and check it appears in the UI.
There was a problem hiding this comment.
oh well, that actually worked, thanks 😅
There was a problem hiding this comment.
uuuhm sorry, done 😅 but we might also wait for nextcloud-libraries/nextcloud-vue#6434 with this, wdyt?
There was a problem hiding this comment.
The modal opacity change does not require any change in the assistant so we can merge this PR IMO.
There was a problem hiding this comment.
No, but with that we could keep the title (do we want to keep it?)
There was a problem hiding this comment.
Oh right, if the frame is not transparent anymore, then the issue is gone. Let's wait and close this PR if nextcloud-libraries/nextcloud-vue#6434 goes in.
It would be weird to remove the title while the frame is transparent and add it again when the frame becomes opaque.
janepie
force-pushed
the
fix/no-modal-title
branch
from
893118c to
4c5e0cd
Compare
| @@ -6,7 +6,7 @@ | |||
| <NcModal v-if="show" | |||
| :size="modalSize" | |||
| :can-close="false" | |||
| :name="t('assistant', 'Nextcloud Assistant')" | |||
| :aria-label="t('assistant', 'Nextcloud Assistant')" | |||
There was a problem hiding this comment.
You do not have to wait for the fix you can already force it:
| :aria-label="t('assistant', 'Nextcloud Assistant')" | |
| dark | |
| :name="t('assistant', 'Nextcloud Assistant')" |
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
janepie
force-pushed
the
fix/no-modal-title
branch
from
4c5e0cd to
a2cf732
Compare
fixes #118
keeps the string as labelId for accessibility reasons