fix: add HTTPS toggle back in HaRP #567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request reintroduces the HTTPS toggle for HaRP by removing the condition that previously hid it.
- Removed the v-if="!isHarp" condition to always render the HTTPS toggle.
- Ensures that HaRP configurations now include the HTTPS toggle functionality.
Comments suppressed due to low confidence (1)
src/components/DaemonConfig/ManageDaemonConfigModal.vue:109
- Consider adding test cases to validate the behavior of the HTTPS toggle in HaRP configurations since the condition has been removed and the toggle will now appear unconditionally.
<NcCheckboxRadioSwitch v-if="!isHarp"
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Collaborator
Author
|
this would need additional fixups because of special handling of "protocol" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.