-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0 - change to an ansible collection #206
Conversation
8339f20
to
d3283b0
Compare
Release Drafter considers all PRs to main, except with tag |
Ok but I have a doubt : last time I edited the release draft to add a comment that this was the last release as a role, but this comment is not in the 1.8.0 release. |
I expect troubles with galaxy when this PR is merged. I haven't found doc about converting a role into a collection for galaxy (and keeping stats) I didn't found doc about transferring a role in galaxy to an other organization either... |
@aalaesar I also had the same problem. Probably there was a merge of PR after your edit and then Release-Drafter overwritten it. This is why currently I edit after the release to be 100% safe =p Also, regarding problems when this PR is merged, I also expect. The sooner we do it, the better. We can make PR fixes as we go, when we have a change like that is 99.99% chance something will break. It is ok if we accept that and keep fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a look on whole PR. I was able to verify all file moves, yml and other. I've not verified python plugins (I think nothing has changed since last review by @staticdev).
@aalaesar I think you will need somehow to rebase to be able to merge since Github says there is a conflict in meta/main.yml |
* add module to run occ commands * create common documentation for occ modules * make common arguments specs * apply black formatting
apparently I missed this line during the rebase.
inspired from the kubernetes.core collection readme
Lets go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Preparing release
@staticdev can the release drafter manage all the changes here or should we edit it ? I noted that is has overwritten my comments on the draft release last time.