Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0 - change to an ansible collection #206

Merged
merged 22 commits into from
Feb 18, 2023
Merged

Release 2.0 - change to an ansible collection #206

merged 22 commits into from
Feb 18, 2023

Conversation

aalaesar
Copy link
Member

@aalaesar aalaesar commented Feb 9, 2023

Preparing release
@staticdev can the release drafter manage all the changes here or should we edit it ? I noted that is has overwritten my comments on the draft release last time.

@aalaesar aalaesar changed the title Relase 2.0 - change to an ansible collection Release 2.0 - change to an ansible collection Feb 9, 2023
@aalaesar aalaesar requested review from staticdev and wiktor2200 and removed request for staticdev February 9, 2023 08:31
@aalaesar aalaesar force-pushed the 2.0-dev branch 2 times, most recently from 8339f20 to d3283b0 Compare February 9, 2023 09:08
@staticdev
Copy link
Collaborator

staticdev commented Feb 9, 2023

Preparing release @staticdev can the release drafter manage all the changes here or should we edit it ? I noted that is has overwritten my comments on the draft release last time.

Release Drafter considers all PRs to main, except with tag skip-changelog as one change. In this case, makes sense to edit manually since it is a special case.

@aalaesar
Copy link
Member Author

aalaesar commented Feb 9, 2023

Preparing release @staticdev can the release drafter manage all the changes here or should we edit it ? I noted that is has overwritten my comments on the draft release last time.

Release Drafter considers all PRs to main, except with tag skip-changelog as one change. In this case, makes sense to edit manually since it is a special case.

Ok but I have a doubt : last time I edited the release draft to add a comment that this was the last release as a role, but this comment is not in the 1.8.0 release.
unless someone removed it ?

@aalaesar aalaesar marked this pull request as ready for review February 9, 2023 21:29
@aalaesar
Copy link
Member Author

I expect troubles with galaxy when this PR is merged.

I haven't found doc about converting a role into a collection for galaxy (and keeping stats)
could be a nice exp for when transferring to nextcloud (but it will have a larger exposure so good stats may not be that hard to get)

I didn't found doc about transferring a role in galaxy to an other organization either...

@staticdev
Copy link
Collaborator

staticdev commented Feb 10, 2023

I expect troubles with galaxy when this PR is merged.

I haven't found doc about converting a role into a collection for galaxy (and keeping stats) could be a nice exp for when transferring to nextcloud (but it will have a larger exposure so good stats may not be that hard to get)

I didn't found doc about transferring a role in galaxy to an other organization either...

@aalaesar I also had the same problem. Probably there was a merge of PR after your edit and then Release-Drafter overwritten it. This is why currently I edit after the release to be 100% safe =p

Also, regarding problems when this PR is merged, I also expect. The sooner we do it, the better. We can make PR fixes as we go, when we have a change like that is 99.99% chance something will break. It is ok if we accept that and keep fixing.

Copy link
Collaborator

@wiktor2200 wiktor2200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look on whole PR. I was able to verify all file moves, yml and other. I've not verified python plugins (I think nothing has changed since last review by @staticdev).

galaxy.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
@staticdev
Copy link
Collaborator

@aalaesar I think you will need somehow to rebase to be able to merge since Github says there is a conflict in meta/main.yml

@staticdev
Copy link
Collaborator

Lets go.

Copy link
Collaborator

@wiktor2200 wiktor2200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@aalaesar aalaesar merged commit 98c4b36 into main Feb 18, 2023
@aalaesar aalaesar deleted the 2.0-dev branch February 18, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants