Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable preinstalled apps after installation #188

Merged
merged 12 commits into from
Jan 25, 2023

Conversation

staticdev
Copy link
Collaborator

@staticdev staticdev commented Jan 6, 2023

Follow-up from #150

  • Add example on README
  • Add example on coverge for molecule test

@staticdev
Copy link
Collaborator Author

staticdev commented Jan 6, 2023

@aalaesar @wiktor2200 @jspaans91 I tried to resurrect this feature, but not sure how is the intended use do disable an app. Were any of you successful testing it? Maybe can you help me adding an example of useful/common app to disable?

@jspaans91
Copy link
Contributor

Hi @staticdev,

Sorry for not respond in the other PR. I'll respond with an example this weekend. I made multiple successful deployments with the version I had committed.

Copy link
Member

@aalaesar aalaesar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in this comment (but I switched disabled with enabled in my example 😨 )
This can be achieved in one task with a loop and I would prefer this simplier implementation:

  • I don't think it is required to fetch the list of app prior to disabling any
  • it is better of readability and idempotence display to loop over all apps declared as "I want this disabled" in the var by having the changed state defined in function of the occ app:disable command's stdout/err.

Regards,
Aal

PS: I'll seriously consider doing a module for managing nextcloud apps once the repo is in the nextcloud organization.

tasks/nc_installation.yml Outdated Show resolved Hide resolved
Co-authored-by: Marc Crebassa <aalaesar@gmail.com>
tasks/nc_installation.yml Outdated Show resolved Hide resolved
staticdev and others added 2 commits January 14, 2023 09:20
Co-authored-by: Marc Crebassa <aalaesar@gmail.com>
@staticdev
Copy link
Collaborator Author

@jspaans91 friendly ping on the example ;D I want to merge this one.

@aalaesar aalaesar dismissed their stale review January 23, 2023 23:28

i comited some code

@aalaesar
Copy link
Member

Should be all that was missing.
can you review @staticdev ?
I've commited to much to properly review

@aalaesar
Copy link
Member

aalaesar commented Jan 23, 2023

ho @staticdev I just realised that tests playbook under /tests/ are not used anymore. I am right ?
but that mean that code coverage has reduced. 😞

molecule/default/latest-converge.yml Show resolved Hide resolved
tests/nextcloud_mysql.yml Show resolved Hide resolved
@aalaesar aalaesar changed the title WIP: Add disable apps Allow to disable preinstalled apps after installation Jan 24, 2023
@staticdev
Copy link
Collaborator Author

Lgtm @aalaesar ?

@aalaesar aalaesar merged commit 139ffc5 into main Jan 25, 2023
@aalaesar aalaesar deleted the feature/disable-apps branch January 25, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants