-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable preinstalled apps after installation #188
Conversation
@aalaesar @wiktor2200 @jspaans91 I tried to resurrect this feature, but not sure how is the intended use do disable an app. Were any of you successful testing it? Maybe can you help me adding an example of useful/common app to disable? |
Hi @staticdev, Sorry for not respond in the other PR. I'll respond with an example this weekend. I made multiple successful deployments with the version I had committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said in this comment (but I switched disabled with enabled in my example 😨 )
This can be achieved in one task with a loop and I would prefer this simplier implementation:
- I don't think it is required to fetch the list of app prior to disabling any
- it is better of readability and idempotence display to loop over all apps declared as "I want this disabled" in the var by having the changed state defined in function of the
occ app:disable
command's stdout/err.
Regards,
Aal
PS: I'll seriously consider doing a module for managing nextcloud apps once the repo is in the nextcloud organization.
Co-authored-by: Marc Crebassa <aalaesar@gmail.com>
Co-authored-by: Marc Crebassa <aalaesar@gmail.com>
@jspaans91 friendly ping on the example ;D I want to merge this one. |
Should be all that was missing. |
ho @staticdev I just realised that tests playbook under /tests/ are not used anymore. I am right ? |
Lgtm @aalaesar ? |
Follow-up from #150