Skip to content

[stable-3.18] Query Param needs serial uid #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #9261

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9271.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.18PR
Warnings109109
Errors00

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 48
Internationalization Warnings 9
Malicious code vulnerability Warnings 51
Multithreaded correctness Warnings 9
Performance Warnings 65
Security Warnings 40
Dodgy code Warnings 101
Total 351

SpotBugs (stable-3.18)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 48
Internationalization Warnings 9
Malicious code vulnerability Warnings 51
Multithreaded correctness Warnings 9
Performance Warnings 65
Security Warnings 40
Dodgy code Warnings 101
Total 351

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #9271 (b3aa901) into stable-3.18 (73c1c9e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           stable-3.18    #9271   +/-   ##
============================================
  Coverage        31.00%   31.01%           
============================================
  Files              501      501           
  Lines            38213    38213           
  Branches          5286     5286           
============================================
+ Hits             11849    11852    +3     
+ Misses           24609    24608    -1     
+ Partials          1755     1753    -2     
Impacted Files Coverage Δ
...ain/java/com/nextcloud/android/sso/QueryParam.java 100.00% <ø> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0.00%> (-1.20%) ⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java 78.15% <0.00%> (-0.69%) ⬇️
...ncloud/android/operations/UploadFileOperation.java 60.39% <0.00%> (-0.33%) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 38.90% <0.00%> (-0.19%) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 25.00% <0.00%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 24.75% <0.00%> (+0.08%) ⬆️
...loud/android/datamodel/FileDataStorageManager.java 57.17% <0.00%> (+0.23%) ⬆️
.../java/com/owncloud/android/utils/DisplayUtils.java 34.13% <0.00%> (+2.00%) ⬆️

@AlvaroBrey AlvaroBrey merged commit 68b814a into stable-3.18 Nov 15, 2021
@AndyScherzinger AndyScherzinger deleted the backport/9261/stable-3.18 branch November 19, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants