Photos -> Media/Gallery #6820
Photos -> Media/Gallery #6820
Conversation
|
This should fix #1269, too |
tobiasKaminsky
force-pushed
the
media
branch
from
43ace6e to
81f9f41
Compare
tobiasKaminsky
force-pushed
the
media
branch
from
81f9f41 to
c2b5d07
Compare
|
@tobiasKaminsky |
🙈🙈🙈 This should not be the case… |
|
Tested on try.nextcloud.com there it's working. So it seams to be a problem on my side. |
|
Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/ui/asynctasks/GallerySearchTask.java 10
- src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.java 6
See the complete overview on Codacy |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16284-IT-master |
|
It's working. |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16284-IT-stable |
|
was doing some testing and this seems to work a lot better with loading the media and photos. Looks like this might fix #7182 |
|
only thing i noticed was when view the photos from the folders they load correctly. If you go under the media tab they dont load in the correct order maybe add an option to sort by and it only load 133 photos and then it dosent update |
AndyScherzinger
force-pushed
the
media
branch
from
9153f69 to
9c14b52
Compare
changed photos -> media Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
force-pushed
the
media
branch
from
9c14b52 to
56776c9
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/6820.apk |
|
stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16571-Screenshot-stable-light-blue |
|
master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16571-Screenshot-master-light-blue |
CodacyLint
SpotBugs (new)
SpotBugs (master)
|
|
stable-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16571-Screenshot-stable-dark-blue |
|
master-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16571-Screenshot-master-dark-blue |
|
@tobiasKaminsky when clicking the media tab it only populates 134 photos and they are not categorize properly |
|
@axheli does it load the next bunch of files when you scroll to the bottom and can you elaborate what you want by categorization? (we just show whatever the server returns) |
|
@AndyScherzinger it will not load more when I go to the bottom it only loads 134 and under the media tab there's no option to categorize by date etc under the file tab ive already seclcted by newest first |
|
@axheli Thanks for the info. Could you maybe open a new issue referencing this PR? That would be great ❤️ |
|
@AndyScherzinger You're Welcome! just created the ticket ❤️ |
Photos -> Media/Gallery Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Fix #6795
removed outdated search enums
changed photos -> media/gallery
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests