enhancement(settings): m3 theme selection dialog#16457
Merged
AndyScherzinger merged 7 commits intomasterfrom Feb 6, 2026
Merged
enhancement(settings): m3 theme selection dialog#16457AndyScherzinger merged 7 commits intomasterfrom
AndyScherzinger merged 7 commits intomasterfrom
Conversation
alperozturk96
changed the title
alperozturk96
requested review from
AndyScherzinger,
ZetaTom and
tobiasKaminsky
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
settings-dark-mode-dialog
branch
from
74088e6 to
17c4356
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
added
the
ux-enhancement
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16457.apk |
kra-mo
approved these changes
Feb 6, 2026
AndyScherzinger
approved these changes
Feb 6, 2026
Member
|
/backport to stable-3.36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes radio button text color on dark mode
Uses M3 dialog
Adds expandability support to the Settings activity, allowing us to get rid of the limitations of the deprecated, non-AndroidX
PreferenceActivityChanges positive action text
CanceltoOKUses the correct status bar color after selecting theme