fix(share): icons

[alperozturk96]

• Tests written, or not not needed

Fixes

Share internal link alignment
Dropdown icon visibility (only visible if permission name exists)
Converts image views to material icon button since they are button not icon

[AndyScherzinger]

@alperozturk96 What is the webUI displaying? Is it also hiding the element or are we missing something on the client-side?

[alperozturk96]

/backport to stable-3.36

[AndyScherzinger]

If you want a declarative way, current you'd need to set up the Grey color we defined, afaik #666666

The material color is dynamic, so you'd need to call a theming util function for that.

Switching to colorOnSurfaceVariant would force you to change that everywhere in the UI so I wouldn't not do it in this PR but just make the changed one Grey again.

[alperozturk96]

If you want a declarative way, current you'd need to set up the Grey color we defined, afaik #666666

The material color is dynamic, so you'd need to call a theming util function for that.

Switching to colorOnSurfaceVariant would force you to change that everywhere in the UI so I wouldn't not do it in this PR but just make the changed one Grey again.

I kept the icon colors as it is (@color/secondary_text_color - #666666). Then we can save it for other PR.

I will check your first message.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16418.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[kra-mo]

Makes sense from the design side. Let's discuss more on Tuesday :)