Skip to content

fix: read only collection #15883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

fix: read only collection #15883

merged 1 commit into from
Nov 5, 2025
+5 −4

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 31, 2025 •
edited
Loading

  • Tests written, or not not needed

Fixes

Screenshot 2025-10-31 at 15 42 27 
FATAL EXCEPTION: main
Process: com.nextcloud.client, PID: 16378
java.lang.UnsupportedOperationException: Operation is not supported for read-only collection
at com.owncloud.android.utils.DisplayUtils.generateNewThumbnail(DisplayUtils.java:984)
at com.owncloud.android.utils.DisplayUtils.setThumbnailFirstTimeForFile(DisplayUtils.java:831)
at com.owncloud.android.utils.DisplayUtils.setThumbnail(DisplayUtils.java:822)
at com.owncloud.android.ui.adapter.UnifiedSearchCurrentDirItemViewHolder.bind(UnifiedSearchCurrentDirItemViewHolder.kt:46)
at com.owncloud.android.ui.adapter.UnifiedSearchListAdapter.onBindViewHolder(UnifiedSearchListAdapter.kt:192)

Changes

ArrayList used instead of List.

How to reproduce?

  1. Perform a fresh installation of the application.
  2. Query a search (e.g., "a") and submit using the Done action on the keyboard.
  3. Repeat the process multiple times in quick succession and press back from toolbar

@alperozturk96
fix: read only collection
fdbe382 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Oct 31, 2025

/backport to stable-3.34

@tobiasKaminsky tobiasKaminsky merged commit 33feff4 into master Nov 5, 2025
14 of 22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the fix/read-only-collection branch November 5, 2025 09:10
@backportbot backportbot bot mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @tobiasKaminsky