Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 30, 2025

  • Tests written, or not not needed

Changes

Upload conditions are validated before scheduling jobs, ensuring that only eligible uploads are sent to the worker.

Fixes an unnecessary chained call in UploadListActivity and refreshes the UI after worker completed.

Removes startAutoUploadImmediately from UploadListActivity, as auto uploads are already managed by a periodic job. Manually triggering them provides no benefit, if a previous scan was recently completed, it will simply be skipped.
Additionally, retryFailedUploads already handles retrying failed auto uploads.

Handles result of retryFailedUploads in UploadListActivity.

Demo

Screenshot 2025-10-30 at 09 39 29

@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.34

@alperozturk96 alperozturk96 force-pushed the fix/choose-correct-upload-ids-for-retry branch from 6fbdc17 to 36233d8 Compare November 5, 2025 07:47
tobiasKaminsky

This comment was marked as resolved.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/choose-correct-upload-ids-for-retry branch from 36233d8 to 71209dd Compare November 5, 2025 10:54
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15872.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Codacy

Lint

TypemasterPR
Warnings4143
Errors1111

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7373
Dodgy code272272
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total498498

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants