simplify and add documentation for connectivity service impl #15826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
changed the title
alperozturk96
changed the title
alperozturk96
force-pushed
the
update-connectivity-service-impl
branch
from
919115b to
c816746
Compare
alperozturk96
commented
Oct 22, 2025
| } | ||
| } | ||
|
|
||
| private boolean hasNonCellularConnectivity() { |
There was a problem hiding this comment.
Deprecated logic changed with:
boolean isWifi = (nc != null) &&
(nc.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) ||
nc.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET) ||
nc.hasTransport(NetworkCapabilities.TRANSPORT_WIFI_AWARE));
|
Fix tests: 
|
alperozturk96
force-pushed
the
update-connectivity-service-impl
branch
from
c816746 to
cba34ca
Compare
|
test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15826-Unit-test-08-23 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15826.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes duplicated logic
Adds documentation