Skip to content

fix: connectivity service impl #15820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: connectivity service impl #15820

wants to merge 1 commit into from

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 20, 2025 •
edited
Loading

  • Tests written, or not not needed

Fixes: #14681

Changes

  • Adds actual network availability via NET_CAPABILITY_VALIDATED.
  • Does not limit the isInternetWalled logic; if the user can access the public Internet, it can check whether the Internet is walled.
  • isNetworkAndServerAvailable can use isInternetWalled for the check; there is no need to recreate instances.
  • No need to create a new thread for each isNetworkAndServerAvailable call.
  • Removes the deprecated hasNonCellularConnectivity function and uses NetworkCapabilities instead.

@alperozturk96 alperozturk96 linked an issue Oct 20, 2025 that may be closed by this pull request
Upload Failure with "No Internet Connection" Message After Upgrading to Version 3.31.0 on Android App #14681
Open
4 tasks
@alperozturk96 alperozturk96 force-pushed the fix/internet-walled-check-logic branch from 5c72334 to d783dfe Compare October 21, 2025 08:13
@nextcloud nextcloud deleted a comment from github-actions bot Oct 21, 2025
@alperozturk96 alperozturk96 mentioned this pull request Oct 21, 2025
Open
4 tasks
@alperozturk96 alperozturk96 changed the title fix: internet walled check logic fix: connectivity service impl Oct 21, 2025
@alperozturk96 alperozturk96 force-pushed the fix/internet-walled-check-logic branch 2 times, most recently from e973ca8 to facd5b2 Compare October 21, 2025 09:06
@nextcloud nextcloud deleted a comment from github-actions bot Oct 21, 2025
@alperozturk96 alperozturk96 force-pushed the fix/internet-walled-check-logic branch from facd5b2 to d1c1436 Compare October 22, 2025 11:46
@alperozturk96 alperozturk96 marked this pull request as draft October 22, 2025 11:58
@github-actions
Copy link

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15820-Unit-test-11-58

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15820.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

2. developing don't merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upload Failure with "No Internet Connection" Message After Upgrading to Version 3.31.0 on Android App

3 participants

@alperozturk96 @tobiasKaminsky