Skip to content

Conversation

alexknop
Copy link
Collaborator

@alexknop alexknop commented Sep 9, 2025

There are 16 SpotBugs under

Bad practice:
RV: Bad use of return value from method (16: 0/16/0/0)
Method ignores exceptional return value (16: 0/16/0/0)

Solution:
Leveraging the more modern java.nio.Files library and conducting these make directory, delete, etc. functions via that.
Changing a Submit to an Execute function

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containsBidiControlCharacters and some other functions are missing.

Signed-off-by: Alex <knopalex@msu.edu>
@alexknop
Copy link
Collaborator Author

alexknop commented Oct 7, 2025

@alperozturk96 This is fixed, not sure what happened before.

Copy link

github-actions bot commented Oct 7, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Copy link

github-actions bot commented Oct 7, 2025

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants