feat: better offline operations notification handling #15451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
commented
Aug 27, 2025
| setLargeIcon(BitmapFactory.decodeResource(context.resources, R.drawable.notification_icon)) | ||
| setStyle(NotificationCompat.BigTextStyle()) | ||
| priority = NotificationCompat.PRIORITY_LOW | ||
| setChannelId(NotificationUtils.NOTIFICATION_CHANNEL_DOWNLOAD) |
Collaborator
Author
There was a problem hiding this comment.
This line was overriding the NOTIFICATION_CHANNEL_BACKGROUND_OPERATIONS thus it needs to be removed.
4 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ion action Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
feat/better-offline-operation-notification-handling
branch
from
373a91f to
1c47a34
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15451.apk |
kra-mo
approved these changes
Aug 28, 2025
alperozturk96
deleted the
feat/better-offline-operation-notification-handling
branch
4 tasks
Collaborator
Author
|
/backport to stable-3.33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Multiple offline operations can fail, and users may receive notifications for each failure. If a user attempts to execute the same operation again, the notification may reappear (e.g. #15420 (comment)). In the worker, certain offline operations are canceled and removed from the database. For example, when an operation completes successfully, or if it is a rename or delete operation. In the case of rename or delete operations, conflicts may occur; to prevent overwriting the server’s latest changes, the worker only informs the user instead of executing the action automatically.
Changes
This PR introduces a new notification action for failed offline operations, allowing users to manually remove them if they do not wish to retry.
Additionally, the offline operations worker now uses a dedicated notification channel, giving users the option to manage or disable these notifications independently.
Note: Adding a more descriptive label for the cancel action, such as "Cancel Offline Operation," could make the notification appear cluttered, as the title already conveys the purpose of the notification.