split up set status dialog

[tobiasKaminsky]

• Tests written, or not not needed

With status shown

[alperozturk96]

Please reduce lint warnings and solve git conflicts.

[kra-mo]

Looks nice :)

Just three small nitpicks:

1. The color discrepancy here looks off:

Could a color that respects the overall tint be used for the statuses?

2. Some more top/bottom padding for these statuses would be nice:

3. The differing text size and small amount of padding for this dropdown also looks weird:

My immediate idea here would be to do something like this instead:

[tobiasKaminsky]

For the grey status background I will check back with Alper and Tom.

[tobiasKaminsky]

Android

• green outline on dark mode
• remove greyish background of "emoji" selection

[tobiasKaminsky]

@kra-mo ^

[tobiasKaminsky]

I aligned it, does this look better?

[tobiasKaminsky]

[AndyScherzinger]

I'd suggest to make the headlines bold to differenciate them from the regular text, also would match examples like https://m3.material.io/components/bottom-sheets/guidelines#0fe19260-d2b4-4058-8f2d-aac7fa14f4c8

[AndyScherzinger]

could come later tough

[kra-mo]

I aligned it, does this look better?

Oh yeah, definitely :)

Thanks!

[kra-mo]

Just one small thing: It would be nice if the "Clear status after" dropdown could get a bit more top/bottom padding as shown here. That's all I'll bother you about now :)

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15441.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	48	48
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	59	59
Correctness	68	68
Dodgy code	280	280
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	48	48
Security	18	18
Total	518	518

fixed