Skip to content

Fix Screenshot Test #15282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 31, 2025
Merged

Fix Screenshot Test #15282

merged 27 commits into from
Jul 31, 2025

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jul 30, 2025

  • Tests written, or not not needed

Before

Screenshot 2025-07-30 at 15 51 31 Screenshot 2025-07-30 at 15 51 58

After

These (DialogFragmentIT, SendShareDialogTest) will be handled in different PR.

Screenshot 2025-07-30 at 17 23 52

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 changed the title Fix screenshot test v3 Fix Screenshot Test Jul 30, 2025
Signed-off-by: alperozturk <alper_ozturk@proton.me>
…cations[emulator-5554 - 8.1.0] FAILED

	java.lang.NullPointerException: Parameter specified as non-null is null: method com.***.utils.GlideHelper.loadIntoImageView, parameter client
	at com.***.utils.GlideHelper.loadIntoImageView(Unknown Source:7)

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@@ -136,7 +136,12 @@ object GlideHelper {
}

@Suppress("UNCHECKED_CAST", "TooGenericExceptionCaught", "ReturnCount")
private fun <T> createRequestBuilder(context: Context, client: NextcloudClient, url: String?): RequestBuilder<T>? {
private fun <T> createRequestBuilder(context: Context, client: NextcloudClient?, url: String?): RequestBuilder<T>? {
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes for test

Image

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15282.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings4848
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6262
Correctness6363
Dodgy code300300
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total536536

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Jul 30, 2025

These (DialogFragmentIT, SendShareDialogTest) will be handled in different PR.

Screenshot 2025-07-30 at 17 21 56

Copy link

@alperozturk96 alperozturk96 merged commit 6985ce0 into master Jul 31, 2025
18 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix-screenshot-test-v3 branch July 31, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants