Check Storage Permission Before Upload

[alperozturk96]

• Tests written, or not not needed

Issue

Previously granted MANAGE_EXTERNAL_STORAGE or Only Media Access permission can be revoked if the app hasn't been used for a few months (e.g. if user not opens the app just using the app for auto upload) or after a system upgrade.

Some other OS implementations may handle this differently, so we need to cover this edge case as well.
Also, it seems that some users have experienced this issue before and resolved it by re-granting the permission.

#15218 (comment)
#15039 (comment)

Changes

Notes

PermissionUtil.requestExternalStoragePermission cannot be used to display the same permission dialog that appears at the beginning of the application, as it depends on AppCompatActivity. Therefore, we inform the user and provide them with the option to choose between the standard app permission or full file access.

@ZetaTom

Additionally, instead of handling the error after a failed upload, we proactively check for the necessary permissions before initiating the upload. This approach prevents unnecessary calls and simplifies the logic flow.

All files access action

App permissions action

We cannot redirect to the directly to the storage permission page. There is no intent action for that.

[alperozturk96]

Looks like full file access permission fixed the issue, please read the issue and comments.

#15039 (comment)
#15039 (comment)
#15039 (comment)
#15039 (comment)
#15039 (comment)

pr is updated

[alperozturk96]

/backport to stable-3.32

[tobiasKaminsky]

This is set for one operation, but what if we have multiple runs?
E.g. user uploads 5x, one after the other?

Then it is always being reset and the user will receive 5x the "error" message?

[alperozturk96]

It's using same notification id also I added check for active notification thus it will only display one notification.

Screen.Recording.2025-08-14.at.09.08.55.mov

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	48	48
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	60	60
Correctness	62	62
Dodgy code	296	296
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	50	50
Security	18	18
Total	531	531

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15240.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

https://github.com/nextcloud/android/security/code-scanning/246

---

Already immutable and has specific action.

private fun getActionPendingIntent(context: Context, actionType: UploadFileBroadcastReceiverActions): PendingIntent {
    val intent = Intent(context, UploadFileBroadcastReceiver::class.java).apply {
        action = "com.owncloud.android.ACTION_UPLOAD_FILE_PERMISSION"
        putExtra(UploadFileBroadcastReceiver.ACTION_TYPE, actionType)
    }

    return PendingIntent.getBroadcast(
        context,
        actionType.ordinal,
        intent,
        PendingIntent.FLAG_IMMUTABLE
    )
}