Skip to content

Warn Users About Invalid Filenames During Download #14834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Warn Users About Invalid Filenames During Download #14834

wants to merge 4 commits into from
+76 −4

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 28, 2025 •
edited
Loading

  • Tests written, or not not needed

How to Reproduce

  1. Upload a file from the web application that contains the ">" character in its name.
  2. Attempt to download the file from the client.

Note

A toast message is used instead of a snackbar because the view is not accessible in the DownloadFileOperation.

Demo

Screen.Recording.2025-04-28.at.15.55.53.mp4

@alperozturk96 alperozturk96 linked an issue Apr 28, 2025 that may be closed by this pull request
Android client fails to download files with ">" in the name #14772
Open
4 tasks
@alperozturk96 alperozturk96 force-pushed the warn-user-for-invalid-filename branch 2 times, most recently from bd8ce5c to 0890e58 Compare April 29, 2025 07:52
tobiasKaminsky

This comment was marked as resolved.

Sign in to view

@alperozturk96
fix
d4d2f13 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix
0cfadee 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the warn-user-for-invalid-filename branch from 0890e58 to 0cfadee Compare April 30, 2025 11:43
@alperozturk96
add reference for isValidExtFilenameChar
6868915 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add tests
7c0a4c6 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5451
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5859
Dodgy code292280
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5149
Security1818
Total500487

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14834.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 added the ux-enhancement Improvements that refine user interactions, accessibility, or overall usability label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review ux-enhancement Improvements that refine user interactions, accessibility, or overall usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android client fails to download files with ">" in the name
3 participants
@alperozturk96 @tobiasKaminsky @ZetaTom