Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open PDF Files Directly #14759

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Open PDF Files Directly #14759

wants to merge 3 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 4, 2025 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
fix
9005175 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unnecessary logic
ed74625 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add readyForPreview
4800812 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the open-pdf-file-directly branch from d1092b0 to 4800812 Compare April 4, 2025 13:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14759.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alperozturk96