Add Client Repositories #14722
Open
Add Client Repositories #14722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
add-client-repository
branch
from
59fa2cf to
147c193
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
add-client-repository
branch
from
d0165a1 to
d8d085d
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14722.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14722-Screenshot-blue-Light-13-56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our codebase, we have duplicated logic for creating
OwnCloudClientandNextcloudClientinstances. In Java files, this requires manually creating a new thread, handling exceptions, and switching back to the main thread after initializing the client. While Kotlin simplifies this process, it still requires explicit handling.Performing networking operations directly within activities leads to bloated and less maintainable code. This pull request introduces a repository pattern to encapsulate client creation and networking logic, improving code reusability, separation of concerns, and maintainability.