Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - Prevent Unnecessary Gallery Binding #14692

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BugFix - Prevent Unnecessary Gallery Binding #14692

wants to merge 3 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 17, 2025 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
prevent unnecessary calls
522f7e7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add filesDeleted to the parsemedia
8b2f0e0 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/gallery-unnecessary-rebind branch from 31568d7 to 8b2f0e0 Compare March 20, 2025 13:52
@alperozturk96
fix git conflicts
adffc3f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14692-Unit-test-13-56

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14692.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alperozturk96