Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Room for filelist table reads #11098

Merged
merged 17 commits into from
Dec 16, 2022
Merged

Use Room for filelist table reads #11098

merged 17 commits into from
Dec 16, 2022

Commits on Dec 13, 2022

  1. Use Room/DAO for getFolderContent 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    cdeff16 View commit details
    Browse the repository at this point in the history

  2. Missing newline (detekt) 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    092a305 View commit details
    Browse the repository at this point in the history

  3. Seems that timestamps need Long rather than Int 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1d44674 View commit details
    Browse the repository at this point in the history

  4. Convert NULL values for integer/long columns to 0 (SpotBugs) 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    45b9006 View commit details
    Browse the repository at this point in the history

  5. Old implementation of getFolderContent ordered results by file name 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    32a7120 View commit details
    Browse the repository at this point in the history

  6. Use Room/DAO for getFileById 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7118041 View commit details
    Browse the repository at this point in the history

  7. FileEntity: fix parent and contentLength types 

    Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
    @AlvaroBrey @starypatyk
    AlvaroBrey authored and starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    dd8a702 View commit details
    Browse the repository at this point in the history

  8. Simplify getFileById - as suggested in review comment 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5d8bb3e View commit details
    Browse the repository at this point in the history

  9. Use Room/DAO for other getFileByX and fileExists 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8272fac View commit details
    Browse the repository at this point in the history

  10. Use Room/DAO for getGalleryItems and getAllFiles 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e76201d View commit details
    Browse the repository at this point in the history

  11. Use Room/DAO for getFolderWithDescendants (used by moveLocalFile) and… 

    … finally remove createFileInstance(cursor) - no longer needed

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8ec6e3a View commit details
    Browse the repository at this point in the history

  12. SpotBugs 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    9cbaa00 View commit details
    Browse the repository at this point in the history

  13. spotlessKotlinCheck 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4df8946 View commit details
    Browse the repository at this point in the history

  14. Fix compilation of tests (revert marking getFileByEncryptedRemotePath… 

    … as @nullable)

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0fb3c92 View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Dariusz Olszewski <8277636+starypatyk@users.noreply.github.com>
    @starypatyk @AlvaroBrey
    starypatyk and AlvaroBrey committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1a669e4 View commit details
    Browse the repository at this point in the history

  16. Apply suggestion from code review - FileDataStorageManager 

    Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Dariusz Olszewski <8277636+starypatyk@users.noreply.github.com>
    @starypatyk @AlvaroBrey
    starypatyk and AlvaroBrey committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    07f61fc View commit details
    Browse the repository at this point in the history

  17. Remove TODOs as discussed 

    Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
    @starypatyk
    starypatyk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    69344bd View commit details
    Browse the repository at this point in the history