Add direct endpoint api #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasKaminsky
force-pushed
the
directEditing
branch
from
fd06ee2 to
0b89600
Compare
tobiasKaminsky
force-pushed
the
directEditing
branch
from
beeb7ec to
f28477f
Compare
...om/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperationTest.java
Outdated
Show resolved
Hide resolved
...om/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperationTest.java
Show resolved
Hide resolved
...om/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperationTest.java
Outdated
Show resolved
Hide resolved
...om/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperationTest.java
Show resolved
Hide resolved
...om/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperation.java
Outdated
Show resolved
Hide resolved
...d/android/lib/resources/directediting/DirectEditingObtainListOfTemplatesRemoteOperation.java
Outdated
Show resolved
Hide resolved
| private String filePath; | ||
| private String editor; | ||
|
|
||
| public DirectEditingOpenFileRemoteOperation(String filePath, String editor) { |
|
@tobiasKaminsky looks good to me. Just some minor comments about further utilization of lombok 👍 |
tobiasKaminsky
force-pushed
the
directEditing
branch
4 times, most recently
from
fba5598 to
04cb1c1
Compare
AndyScherzinger
previously approved these changes
Dec 10, 2019
|
Looks good to me 👍 |
|
Tests fails as @juliushaertl seems to removed the templates. |
AndyScherzinger
previously approved these changes
Dec 12, 2019
Lint
SpotBugs (new)
SpotBugs (master)
|
tobiasKaminsky
force-pushed
the
directEditing
branch
from
b3ae955 to
6a639ea
Compare
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1346 |
juliusknorr
reviewed
Dec 16, 2019
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1347 |
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1348 |
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
|
@tobiasKaminsky Spotbugs is drunk... |
|
Hehe. Somehow yes…I will change it accordingly, once all tests are green. |
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1351 |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
directEditing
branch
from
ff291a9 to
1c603f3
Compare
|
Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/lib/common/TemplateList.java 1
- src/main/java/com/owncloud/android/lib/resources/status/GetCapabilitiesRemoteOperation.java 1
- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingOpenFileRemoteOperationTest.java 1
- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainListOfTemplatesRemoteOperationTest.java 1
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperation.java 5
- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperationTest.java 1
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainListOfTemplatesRemoteOperation.java 4
- src/main/java/com/owncloud/android/lib/common/Creator.java 3
- src/androidTest/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperationTest.java 1
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingObtainRemoteOperation.java 4
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingOpenFileRemoteOperation.java 4
Clones added
============
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingCreateFileRemoteOperation.java 1
- src/main/java/com/nextcloud/android/lib/resources/directediting/DirectEditingOpenFileRemoteOperation.java 1
See the complete overview on Codacy |
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1353 |
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1354 |
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Lint
SpotBugs (new)
SpotBugs (master)
|
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1355 |
Lint
SpotBugs (new)
SpotBugs (master)
|
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1356 |
|
Last failing test will be resolved via nextcloud/text#478 |
Lint
SpotBugs (new)
SpotBugs (master)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me