Reverse proxy docs - Add comment to use Docker DNS in nginx config example - #8604
Open
tvoirand wants to merge 1 commit into
Open
Reverse proxy docs - Add comment to use Docker DNS in nginx config example#8604tvoirand wants to merge 1 commit into
tvoirand wants to merge 1 commit into
Conversation
Signed-off-by: Thibaut Voirand <thibaut.voirand@murena.io>
Collaborator
|
resolver should not be needed since the proxy_pass goes to an ip, not a hostname/domain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your work on this great project!
The reverse proxy docs describe how to adapt the sample web server configuration in a scenario where the reverse proxy is running on the same server in a Docker container. In this scenario there are three options, the first one relying on host networking, and the next two relying on Docker bridge network's DNS name resolution.
I used the Docker bridge network's DNS method with nginx. But without explicitly telling nginx to use the Docker DNS server with a
resolver 127.0.0.11directive, this method fails with the nginx logs giving "no resolver defined to resolve nextcloud-aio-apache".The
resolverdirective is not mentioned in the nginx config example. Adding it as an optional/commented line could help.It does add yet another optional/commented line in the config example, so I guess adding this is a compromise between 1/ keeping the example simple and letting the user adapt by themself versus 2/ helping the user by making the example exhaustive at the risk of cluttering with too much information.
I'm not an expert of nginx in Docker containers, it's possible that some other aspect of my setup made this
resolver 127.0.0.11directive necessary.Resolves: #
Summary
3. to review, feature component)AI (if applicable)