Fix hadolint complaints - #8598
Closed
pabzm wants to merge 2 commits into
Closed
Conversation
9 tasks
Converts all shell-form HEALTHCHECK CMD instructions to exec (JSON array) form. The domaincheck healthcheck relies on shell expansion and the || operator, so it is wrapped as CMD ["sh", "-c", "..."] to preserve behavior. Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> Co-Authored-By: Claude Sonnet 5
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
pabzm
force-pushed
the
fix-dockerfile-lint-json-notation
branch
from
August 20, 2026 15:02
1d24d83 to
b214409
Compare
Member
Author
|
The Docker lint check complains:
I'd prefer to fix this instead of ignoring it, but I'm not sure if using numeric UIDs could break something. @szaimen What do you think? |
Collaborator
|
Why a second PR? #8523 |
Member
Author
|
Because I forgot about yours and just worked on it spontaneously /close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hadolint's complains as visible e.g. in https://github.com/nextcloud/all-in-one/actions/runs/32381178668/job/96464481888
array) form. The domaincheck healthcheck relies on shell expansion and
the || operator, so it is wrapped as CMD ["sh", "-c", "..."] to preserve
behavior.
AIO_TOKENenvironment variable. (I'm not sure why we do that but I don't dare to change that now.)Summary
3. to review, feature component)AI (if applicable)