-
Notifications
You must be signed in to change notification settings - Fork 968
Add COLLABORA_EXTRA_HOSTS option #7362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Keith Wansbrough <keithw@lochan.org>
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please check #1358 first before we dive into this
|
Thanks for the nudge. Going through that again and thinking some more means I may have got a step closer. See my original post and my update in this thread: nextcloud/richdocuments#4906 (comment) . Thanks. |
|
@szaimen if you would prefer to avoid the Looking at containers.json in AIO, it looks like there's no way to pass arbitrary options from compose.yaml to Collabora - the only configurable option is currently the seccomp one. I can think of a couple of approaches, both of which could be done as modifications of this present PR:
Or perhaps there is some way I can get my system working without any of these changes. Happy to proceed on whichever of these paths would be preferable to you. |
|
There is all-in-one/php/templates/includes/optional-containers.twig Lines 180 to 191 in e8d1bce
|
|
It didn't help - I think the (IP and hostname redacted obviously). |
|
Cool, I'll try again once I have #7481 - thank you! |
This is now released with v12.6.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
This PR adds the ability to add extra entries to /etc/hosts on the nextcloud-aio-collabora container.
I need this to work around an issue that I haven't yet fully resolved, to do with Collabora (in response to a request coming via coolwsd) attempting to retrieve config from my instance's external domain, rather than the internal domain. (This may be nextcloud/richdocuments#4906.) I intend to properly debug this and provide a PR later. But this functionality could be useful to others, e.g., #2395.
I didn't understand the function of
update-yaml.sh, nor do I understand what theconfigNameis for, so please let me know if I have missed anything.This would probably be better if it was generalised to allow specifying for any container rather than only nextcloud-aio-collabora. But I didn't know the best way to represent this in config.
Thanks!