-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm chart - allow to add additional trusted domain #4151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
commented
Jan 31, 2024
szaimen
commented
Jan 31, 2024
szaimen
force-pushed
the
enh/4150/add-trusted-domain
branch
from
January 31, 2024 15:19
d9c5b83
to
7dfcb21
Compare
szaimen
force-pushed
the
enh/4150/add-trusted-domain
branch
from
January 31, 2024 15:46
f7d8217
to
cd0915a
Compare
szaimen
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jan 31, 2024
szaimen
commented
Jan 31, 2024
szaimen
force-pushed
the
enh/4150/add-trusted-domain
branch
from
January 31, 2024 16:56
cd0915a
to
3ef89fe
Compare
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/4150/add-trusted-domain
branch
from
January 31, 2024 17:00
3ef89fe
to
ef30eca
Compare
szaimen
commented
Jan 31, 2024
@@ -112,8 +114,6 @@ spec: | |||
value: nextcloud-aio-onlyoffice | |||
- name: ONLYOFFICE_SECRET | |||
value: "{{ .Values.ONLYOFFICE_SECRET }}" | |||
- name: OVERWRITEHOST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess would need to send them the hint that they should check if log in via desktop and/or android and ios app still works...
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4150