improve containeers schema #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
szaimen
changed the base branch from
enh/noid/improve-container-definition
to
main
szaimen
force-pushed
the
enh/noid/improve-containers-schema
branch
2 times, most recently
from
4dac364
to
a0a9538
Compare
szaimen
added
3. to review
szaimen
force-pushed
the
enh/noid/improve-containers-schema
branch
2 times, most recently
from
9a03265
to
92665d8
Compare
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/improve-containers-schema
branch
from
92665d8
to
d4893be
Compare
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/improve-containers-schema
branch
from
d4893be
to
de1eaf7
Compare
delete-merged-branch
bot
deleted the
enh/noid/improve-containers-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1581
This is best reviewed like this: https://github.com/nextcloud/all-in-one/pull/1604/files?diff=unified&w=1
needs rename values of containers definition to match docker-compose values #1595
TODO: add isset to all not-required properties in definitionfetcher
add a version to services (maybe rename it to aio-definition-v1 or something and)
renove not used properties from the containers definition
add further required sub-requirements?not needed as minvalue and additional are setSigned-off-by: Simon L szaimen@e.mail.de