Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX headers #1663

Merged
merged 8 commits into from
May 7, 2024
Merged

Add SPDX headers #1663

merged 8 commits into from
May 7, 2024

Conversation

AndyScherzinger
Copy link
Member

No description provided.

@cypress Cypress

This comment was marked as outdated.

Sign in to view
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx-header branch 2 times, most recently from daf164c to 8f3424c Compare May 2, 2024 08:28
@AndyScherzinger

This comment was marked as outdated.

Sign in to view
@AndyScherzinger
Copy link
Member Author

@jancborchardt can't you name the source and hence license/author of https://github.com/nextcloud/activity/tree/master/img images?

@jancborchardt
Copy link
Member

@jancborchardt can't you name the source and hence license/author of https://github.com/nextcloud/activity/tree/master/img images?

That would be me :D They were contributed under the overall AGPLv3 license.
If possible it would be nice to not include an email address (could be website instead) to prevent spam.

@AndyScherzinger
Copy link
Member Author

If possible it would be nice to not include an email address (could be website instead) to prevent spam.

Yes, doable

@AndyScherzinger
Copy link
Member Author

/compile /

@AndyScherzinger AndyScherzinger marked this pull request as ready for review May 2, 2024 10:10
nickvergessen
nickvergessen reviewed May 2, 2024
View reviewed changes
issue_template.md.license Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files in root are problematic for packaging.
Please move the issue template and the license file to .github

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done via 0420e42

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files in root are problematic for packaging.

We add AUTHORS.md to root with this PR - like on the other apps too.

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx-header branch 3 times, most recently from f3fedc3 to 78a471e Compare May 2, 2024 13:03
nickvergessen
nickvergessen approved these changes May 3, 2024
View reviewed changes
lib/Event/LoadAdditionalScriptsEvent.php Outdated Show resolved Hide resolved
AndyScherzinger and others added 8 commits May 7, 2024 16:29
@AndyScherzinger
chore: Add SPDX headers
4044007 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(ci): Add reuse check
0ddba44 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
docs: Add reuse badge
534986d 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-command @AndyScherzinger
chore(assets): Recompile assets
e63ab8a 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger
Fix(lint): remove empty line
87d79f1 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(docs): add missing author
d0b10a9 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: move issue template to .github
e3611f7 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@artonge @AndyScherzinger
Update licence of LoadAdditionalScriptsEvent to 3.0 or later
d312634 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@AndyScherzinger
Copy link
Member Author

All green now @artonge 💯🎉

@artonge artonge merged commit 81c88e4 into master May 7, 2024
48 checks passed
@artonge artonge deleted the chore/noid/spdx-header branch May 7, 2024 16:41
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone May 7, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

Assignees
No one assigned
Labels
3. to review technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@AndyScherzinger @jancborchardt @nickvergessen @artonge @nextcloud-command