Skip to content

Conversation

@oleksandr-nc
Copy link
Contributor

We will need this in AppAPI in the near future, some kind of endpoint so that we can tell the admins from AppAPI that their HaRP is old and not compatible with the new version of AppAPI. (as currently with DSP it is a disaster)

@oleksandr-nc oleksandr-nc requested a review from kyteinsky as a code owner July 9, 2025 12:23
Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do automated checks for this, like an additional header in app_api for minimum supported version of harp? That is validated in the harp container and returns an error visisble in the logs.

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc oleksandr-nc force-pushed the feat/version-endpoint branch from 083fb52 to 42283fd Compare July 9, 2025 13:25
@oleksandr-nc
Copy link
Contributor Author

Can we do automated checks for this, like an additional header in app_api for minimum supported version of harp? That is validated in the harp container and returns an error visisble in the logs.

I thought of doing it this way initially, but it would greatly complicate the logic of work in AppAPI - where we would have to check the answers everywhere and it would be ugly.
And with this we will be able to simply check all HaRPs during the AppAPI update, for example, or at least during the "TestConnect" button - whatever we will choose.

I wanted to make it not too complicated

@oleksandr-nc oleksandr-nc merged commit a3ec69b into main Jul 9, 2025
3 checks passed
@oleksandr-nc oleksandr-nc deleted the feat/version-endpoint branch July 9, 2025 13:30
@kyteinsky
Copy link
Contributor

fair enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants